diff options
author | Jason A. Donenfeld <Jason@zx2c4.com> | 2021-12-24 19:17:58 +0100 |
---|---|---|
committer | Jason A. Donenfeld <Jason@zx2c4.com> | 2022-01-07 00:25:25 +0100 |
commit | 0d9488ffbf2faddebc6bac055bfa6c93b94056a3 (patch) | |
tree | 5a2001dbfd86c2f2e65cb37c75f560d515a53852 /drivers/usb/cdns3/cdns3-trace.c | |
parent | 9f9eff85a008b095eafc5f4ecbaf5aca689271c1 (diff) |
random: do not sign extend bytes for rotation when mixing
By using `char` instead of `unsigned char`, certain platforms will sign
extend the byte when `w = rol32(*bytes++, input_rotate)` is called,
meaning that bit 7 is overrepresented when mixing. This isn't a real
problem (unless the mixer itself is already broken) since it's still
invertible, but it's not quite correct either. Fix this by using an
explicit unsigned type.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-trace.c')
0 files changed, 0 insertions, 0 deletions