diff options
author | David Howells <[email protected]> | 2023-04-21 23:03:46 +0100 |
---|---|---|
committer | David S. Miller <[email protected]> | 2023-04-22 15:16:39 +0100 |
commit | e0416e7d33361d2ad0bf9f007428346579ac854a (patch) | |
tree | 9c840c2d1f4c72e457db4b9106dbbf54c6ba3281 /drivers/usb/cdns3/cdns3-debug.h | |
parent | 92ce288ccb0d472977b24bd0b7240fc2490a6145 (diff) |
rxrpc: Fix potential race in error handling in afs_make_call()
If the rxrpc call set up by afs_make_call() receives an error whilst it is
transmitting the request, there's the possibility that it may get to the
point the rxrpc call is ended (after the error_kill_call label) just as the
call is queued for async processing.
This could manifest itself as call->rxcall being seen as NULL in
afs_deliver_to_call() when it tries to lock the call.
Fix this by splitting rxrpc_kernel_end_call() into a function to shut down
an rxrpc call and a function to release the caller's reference and calling
the latter only when we get to afs_put_call().
Reported-by: Jeffrey Altman <[email protected]>
Signed-off-by: David Howells <[email protected]>
Tested-by: [email protected]
cc: Marc Dionne <[email protected]>
cc: "David S. Miller" <[email protected]>
cc: Eric Dumazet <[email protected]>
cc: Jakub Kicinski <[email protected]>
cc: Paolo Abeni <[email protected]>
cc: [email protected]
cc: [email protected]
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-debug.h')
0 files changed, 0 insertions, 0 deletions