diff options
| author | Jan Kara <[email protected]> | 2024-08-05 22:12:41 +0200 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2024-08-26 23:53:20 -0400 |
| commit | d3476f3dad4ad68ae5f6b008ea6591d1520da5d8 (patch) | |
| tree | 08c6ca8556271e0e13aac77f139e070c2073504a /drivers/usb/cdns3/cdns3-debug.h | |
| parent | d1bc560e9a9c78d0b2314692847fc8661e0aeb99 (diff) | |
ext4: don't set SB_RDONLY after filesystem errors
When the filesystem is mounted with errors=remount-ro, we were setting
SB_RDONLY flag to stop all filesystem modifications. We knew this misses
proper locking (sb->s_umount) and does not go through proper filesystem
remount procedure but it has been the way this worked since early ext2
days and it was good enough for catastrophic situation damage
mitigation. Recently, syzbot has found a way (see link) to trigger
warnings in filesystem freezing because the code got confused by
SB_RDONLY changing under its hands. Since these days we set
EXT4_FLAGS_SHUTDOWN on the superblock which is enough to stop all
filesystem modifications, modifying SB_RDONLY shouldn't be needed. So
stop doing that.
Link: https://lore.kernel.org/all/[email protected]
Reported-by: Christian Brauner <[email protected]>
Signed-off-by: Jan Kara <[email protected]>
Reviewed-by: Christian Brauner <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-debug.h')
0 files changed, 0 insertions, 0 deletions