diff options
author | Krzysztof Kozlowski <[email protected]> | 2023-06-01 12:25:25 +0200 |
---|---|---|
committer | Vinod Koul <[email protected]> | 2023-06-21 16:31:44 +0530 |
commit | 490937d479abe5f6584e69b96df066bc87be92e9 (patch) | |
tree | 85049f35103224badaa38711b5d90df9c1528473 /drivers/usb/cdns3/cdns3-debug.h | |
parent | a1b828f202ae45b4fce4d21e83679605feb87862 (diff) |
soundwire: qcom: fix storing port config out-of-bounds
The 'qcom_swrm_ctrl->pconfig' has size of QCOM_SDW_MAX_PORTS (14),
however we index it starting from 1, not 0, to match real port numbers.
This can lead to writing port config past 'pconfig' bounds and
overwriting next member of 'qcom_swrm_ctrl' struct. Reported also by
smatch:
drivers/soundwire/qcom.c:1269 qcom_swrm_get_port_config() error: buffer overflow 'ctrl->pconfig' 14 <= 14
Fixes: 9916c02ccd74 ("soundwire: qcom: cleanup internal port config indexing")
Cc: <[email protected]>
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Vinod Koul <[email protected]>
Diffstat (limited to 'drivers/usb/cdns3/cdns3-debug.h')
0 files changed, 0 insertions, 0 deletions