diff options
| author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2013-05-23 12:51:14 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-05-30 20:40:53 +0900 |
| commit | 6028f4c01c2e5626f5279acca7ddbdc2125474a0 (patch) | |
| tree | 5221ae402208dca8c690789250e23246df964ed6 /drivers/staging/comedi | |
| parent | 125a77fcf5836b25720b3076b988b3efa58982bf (diff) | |
staging: comedi: usbduxsigma: tidy up usbduxsub_submit_PwmURBs()
Rename the CamelCase function.
Pass the comedi_device pointer instead of the private data pointer
to the function.
Use a couple local variables to tidy up the function.
Remove the dev_err() message when usb_submit_urb() fails, its just
added noise.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/comedi')
| -rw-r--r-- | drivers/staging/comedi/drivers/usbduxsigma.c | 38 |
1 files changed, 13 insertions, 25 deletions
diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index 3d8f17a7a257..106dbef36ae8 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c @@ -1481,29 +1481,18 @@ static void usbduxsub_pwm_irq(struct urb *urb) } } -static int usbduxsub_submit_PwmURBs(struct usbduxsigma_private *usbduxsub) +static int usbduxsigma_submit_pwm_urb(struct comedi_device *dev) { - int errFlag; - - if (!usbduxsub) - return -EFAULT; + struct usb_device *usb = comedi_to_usb_dev(dev); + struct usbduxsigma_private *devpriv = dev->private; + struct urb *urb = devpriv->urbPwm; /* in case of a resubmission after an unlink... */ - usb_fill_bulk_urb(usbduxsub->urbPwm, - usbduxsub->usbdev, - usb_sndbulkpipe(usbduxsub->usbdev, PWM_EP), - usbduxsub->urbPwm->transfer_buffer, - usbduxsub->sizePwmBuf, usbduxsub_pwm_irq, - usbduxsub->comedidev); - - errFlag = usb_submit_urb(usbduxsub->urbPwm, GFP_ATOMIC); - if (errFlag) { - dev_err(&usbduxsub->interface->dev, - "comedi_: usbduxsigma: pwm: usb_submit_urb error %d\n", - errFlag); - return errFlag; - } - return 0; + usb_fill_bulk_urb(urb, usb, usb_sndbulkpipe(usb, PWM_EP), + urb->transfer_buffer, devpriv->sizePwmBuf, + usbduxsub_pwm_irq, dev); + + return usb_submit_urb(urb, GFP_ATOMIC); } static int usbdux_pwm_period(struct comedi_device *dev, @@ -1552,12 +1541,11 @@ static int usbdux_pwm_start(struct comedi_device *dev, for (i = 0; i < this_usbduxsub->sizePwmBuf; i++) ((char *)(this_usbduxsub->urbPwm->transfer_buffer))[i] = 0; - this_usbduxsub->pwm_cmd_running = 1; - ret = usbduxsub_submit_PwmURBs(this_usbduxsub); - if (ret < 0) { - this_usbduxsub->pwm_cmd_running = 0; + ret = usbduxsigma_submit_pwm_urb(dev); + if (ret < 0) return ret; - } + this_usbduxsub->pwm_cmd_running = 1; + return 0; } |