diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2018-09-26 18:29:04 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-26 09:56:07 -0700 |
| commit | c1a935f6ec5b146aef1de03d1ef135de34f90646 (patch) | |
| tree | 835004e0e6c7aeccbb453aa074dc4150efa92236 /drivers/s390/net/qeth_core_sys.c | |
| parent | a70fee3b0f9007ee16bf0159018ee29684acfac0 (diff) | |
s390/qeth: fix discipline unload after setup error
Device initialization code usually first loads a subdriver
(via qeth_core_load_discipline()), and then runs its setup() callback.
If this fails, it rolls back the load via qeth_core_free_discipline().
qeth_core_free_discipline() expects the options.layer attribute to be
initialized, but on error in setup() that's currently not the case.
Resulting in misbalanced symbol_put() calls.
Fix this by setting options.layer when loading the subdriver.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net/qeth_core_sys.c')
| -rw-r--r-- | drivers/s390/net/qeth_core_sys.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c index fdb67af811f4..970f6c71a66e 100644 --- a/drivers/s390/net/qeth_core_sys.c +++ b/drivers/s390/net/qeth_core_sys.c @@ -432,8 +432,6 @@ static ssize_t qeth_dev_layer2_store(struct device *dev, card->discipline->remove(card->gdev); qeth_core_free_discipline(card); - card->options.layer = QETH_DISCIPLINE_UNDETERMINED; - free_netdev(card->dev); card->dev = ndev; } |