diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-01-12 09:56:25 +0300 |
|---|---|---|
| committer | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2024-01-24 12:34:45 +0200 |
| commit | 890a48ca7b05406c538505a92148de7ab0d50591 (patch) | |
| tree | 8320d69be3b16dc2199cf4b084e6785d4d5dab49 /drivers/platform/x86/silicom-platform.c | |
| parent | 214509e5d61d294193b220f397418e76879f74c0 (diff) | |
platform/x86: silicom-platform: clean up a check
The error message in this code can't be reached because value is either
zero or non-zero. There isn't a third option. Really, it's nicer to
write this as a one liner.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/a58bffb7-0a8b-4195-b273-f65a188ace7b@moroto.mountain
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/silicom-platform.c')
| -rw-r--r-- | drivers/platform/x86/silicom-platform.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c index 6ce43ccb3112..c0910af16a3a 100644 --- a/drivers/platform/x86/silicom-platform.c +++ b/drivers/platform/x86/silicom-platform.c @@ -256,12 +256,7 @@ static void silicom_gpio_set(struct gpio_chip *gc, if (direction == GPIO_LINE_DIRECTION_IN) return; - if (value) - silicom_mec_port_set(channel, 0); - else if (value == 0) - silicom_mec_port_set(channel, 1); - else - pr_err("Wrong argument value: %d\n", value); + silicom_mec_port_set(channel, !value); } static int silicom_gpio_direction_output(struct gpio_chip *gc, |