diff options
author | Palmer Dabbelt <[email protected]> | 2022-09-12 23:48:01 +0100 |
---|---|---|
committer | Palmer Dabbelt <[email protected]> | 2022-09-13 02:06:11 -0700 |
commit | 8f7e001e0325de63a42f23342ac3b8139150c5cf (patch) | |
tree | 3d499d7ce43a19dc236ed45d90f10baba838f8a6 /drivers/net/wwan/iosm/iosm_ipc_protocol.c | |
parent | 20e0fbab16003ae23a9e86a64bcb93e3121587ca (diff) |
RISC-V: Clean up the Zicbom block size probing
This fixes two issues: I truncated the warning's hart ID when porting to
the 64-bit hart ID code, and the original code's warning handling could
fire on an uninitialized hart ID.
The biggest change here is that riscv_cbom_block_size is no longer
initialized, as IMO the default isn't sane: there's nothing in the ISA
that mandates any specific cache block size, so falling back to one will
just silently produce the wrong answer on some systems. This also
changes the probing order so the cache block size is known before
enabling Zicbom support.
CC: [email protected]
CC: Andrew Jones <[email protected]>
CC: Heiko Stuebner <[email protected]>
CC: Atish Patra <[email protected]>
Fixes: 3aefb2ee5bdd ("riscv: implement Zicbom-based CMO instructions + the t-head variant")
Fixes: 1631ba1259d6 ("riscv: Add support for non-coherent devices using zicbom extension")
Reported-by: kernel test robot <[email protected]>
Reported-by: Conor Dooley <[email protected]>
Signed-off-by: Palmer Dabbelt <[email protected]>
[Conor: fixed the redefinition errors]
Tested-by: Conor Dooley <[email protected]>
Signed-off-by: Conor Dooley <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Palmer Dabbelt <[email protected]>
Diffstat (limited to 'drivers/net/wwan/iosm/iosm_ipc_protocol.c')
0 files changed, 0 insertions, 0 deletions