diff options
author | Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> | 2024-09-02 18:36:10 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-09-03 15:28:57 -0700 |
commit | 9748229c90dc4974f56874a2a19e040cc86de67e (patch) | |
tree | 77290c7b091d95bd00a5aa043baef67be8914ce8 /drivers/net/ethernet/microchip/fdma/fdma_api.c | |
parent | d2088ca85ebc38c3e8783442ba2c0f3e5100ac6d (diff) |
net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
This reverts commit bf4d87f884fe8a4b6b61fe4d0e05f293d08df61c because it
introduced dev_err_probe() in non-probe path, which is not desired.
In general, calling dev_err_probe() after successful probe in case of
handling -EPROBE_DEFER error, will set deferred status on the device
already probed. This is however not a problem here now, because
dev_err_probe() in affected places is used for handling errors from
request_firmware(), which does not return -EPROBE_DEFER. Still usage of
dev_err_probe() in such case is not correct, because request_firmware()
could once return -EPROBE_DEFER.
Fixes: bf4d87f884fe ("net: alacritech: Switch to use dev_err_probe()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240902163610.17028-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/microchip/fdma/fdma_api.c')
0 files changed, 0 insertions, 0 deletions