diff options
| author | Nitesh Narayan Lal <[email protected]> | 2021-09-03 11:24:25 -0400 | 
|---|---|---|
| committer | Thomas Gleixner <[email protected]> | 2021-12-10 20:47:39 +0100 | 
| commit | cc493264c01d055742a34cfbaecaffb258dcc58c (patch) | |
| tree | 1ef8da4a127170566af71638acca9c41ce4cc28d /drivers/net/ethernet/intel | |
| parent | b8b9dd525203304d36bd123fca3ce0c3b318339b (diff) | |
ixgbe: Use irq_update_affinity_hint()
The driver uses irq_set_affinity_hint() to update the affinity_hint mask
that is consumed by the userspace to distribute the interrupts. However,
under the hood irq_set_affinity_hint() also applies the provided cpumask
(if not NULL) as the affinity for the given interrupt which is an
undocumented side effect.
To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_update_affinity_hint()
that only updates the affinity_hint pointer.
Signed-off-by: Nitesh Narayan Lal <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Acked-by: Jesse Brandeburg <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'drivers/net/ethernet/intel')
| -rw-r--r-- | drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 | 
1 files changed, 5 insertions, 5 deletions
| diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 0f9f022260d7..66068e17ee1f 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -3247,8 +3247,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)  		/* If Flow Director is enabled, set interrupt affinity */  		if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) {  			/* assign the mask for this irq */ -			irq_set_affinity_hint(entry->vector, -					      &q_vector->affinity_mask); +			irq_update_affinity_hint(entry->vector, +						 &q_vector->affinity_mask);  		}  	} @@ -3264,8 +3264,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter)  free_queue_irqs:  	while (vector) {  		vector--; -		irq_set_affinity_hint(adapter->msix_entries[vector].vector, -				      NULL); +		irq_update_affinity_hint(adapter->msix_entries[vector].vector, +					 NULL);  		free_irq(adapter->msix_entries[vector].vector,  			 adapter->q_vector[vector]);  	} @@ -3398,7 +3398,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter)  			continue;  		/* clear the affinity_mask in the IRQ descriptor */ -		irq_set_affinity_hint(entry->vector, NULL); +		irq_update_affinity_hint(entry->vector, NULL);  		free_irq(entry->vector, q_vector);  	} |