diff options
author | Harini Katakam <harini.katakam@xilinx.com> | 2019-05-07 19:59:10 +0530 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-07 12:26:40 -0700 |
commit | 0504453139ef5a593c9587e1e851febee859c7d8 (patch) | |
tree | 395f6914080e5e7bd294ed7b54a2f3924d3b8c57 /drivers/net/ethernet/intel/igc/igc_main.c | |
parent | ff6ab32bd4e073976e4d8797b4d514a172cfe6cb (diff) |
net: macb: Change interrupt and napi enable order in open
Current order in open:
-> Enable interrupts (macb_init_hw)
-> Enable NAPI
-> Start PHY
Sequence of RX handling:
-> RX interrupt occurs
-> Interrupt is cleared and interrupt bits disabled in handler
-> NAPI is scheduled
-> In NAPI, RX budget is processed and RX interrupts are re-enabled
With the above, on QEMU or fixed link setups (where PHY state doesn't
matter), there's a chance macb RX interrupt occurs before NAPI is
enabled. This will result in NAPI being scheduled before it is enabled.
Fix this macb open by changing the order.
Fixes: ae1f2a56d273 ("net: macb: Added support for many RX queues")
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions