diff options
author | Armin Wolf <W_Armin@gmx.de> | 2024-05-28 22:49:02 +0200 |
---|---|---|
committer | Hans de Goede <hdegoede@redhat.com> | 2024-06-03 11:53:54 +0200 |
commit | 1981b296f858010eae409548fd297659b2cc570e (patch) | |
tree | e491a7b5a6476885c15b1373d2dcdd3e8d92ce1c /drivers/net/ethernet/intel/igc/igc_ethtool.c | |
parent | 078fc56f5c1787a9272373742f817b320c046d1a (diff) |
platform/x86: dell-smbios: Fix wrong token data in sysfs
When reading token data from sysfs on my Inspiron 3505, the token
locations and values are wrong. This happens because match_attribute()
blindly assumes that all entries in da_tokens have an associated
entry in token_attrs.
This however is not true as soon as da_tokens[] contains zeroed
token entries. Those entries are being skipped when initialising
token_attrs, breaking the core assumption of match_attribute().
Fix this by defining an extra struct for each pair of token attributes
and use container_of() to retrieve token information.
Tested on a Dell Inspiron 3050.
Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240528204903.445546-1-W_Armin@gmx.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_ethtool.c')
0 files changed, 0 insertions, 0 deletions