diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-08-20 16:43:46 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-21 17:21:47 -0700 |
| commit | 0ce054f2b891afdd102c8bcc1fc57253c8964e40 (patch) | |
| tree | 5f42646021b424753c161bb0d2abc8d0d054a870 /drivers/net/ethernet/intel/ice/ice_parser_rt.c | |
| parent | d35a3a8f1b7f27ac1ea0f7068dcab0c08846ac44 (diff) | |
ice: Fix a 32bit bug
BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type.
On 32 bit systems, unsigned long is a u32 and the mismatch between u32
and u64 will break things for the high 32 bits.
Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://patch.msgid.link/ddc231a8-89c1-4ff4-8704-9198bcb41f8d@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_parser_rt.c')
| -rw-r--r-- | drivers/net/ethernet/intel/ice/ice_parser_rt.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/intel/ice/ice_parser_rt.c b/drivers/net/ethernet/intel/ice/ice_parser_rt.c index d5bcc266b01e..dedf5e854e4b 100644 --- a/drivers/net/ethernet/intel/ice/ice_parser_rt.c +++ b/drivers/net/ethernet/intel/ice/ice_parser_rt.c @@ -377,11 +377,11 @@ static void ice_pg_exe(struct ice_parser_rt *rt) static void ice_flg_add(struct ice_parser_rt *rt, int idx, bool val) { - rt->pu.flg_msk |= BIT(idx); + rt->pu.flg_msk |= BIT_ULL(idx); if (val) - rt->pu.flg_val |= BIT(idx); + rt->pu.flg_val |= BIT_ULL(idx); else - rt->pu.flg_val &= ~BIT(idx); + rt->pu.flg_val &= ~BIT_ULL(idx); ice_debug(rt->psr->hw, ICE_DBG_PARSER, "Pending update for flag %d value %d\n", idx, val); |