diff options
author | Oleksij Rempel <o.rempel@pengutronix.de> | 2023-03-24 09:06:07 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2023-03-25 11:17:32 +0000 |
commit | 392ff7a84cbca34118ca286dfbfe8aee24605897 (patch) | |
tree | 47c90ed8362318e27c3fd34ccbef0ceba67fc98d /drivers/net/dsa/microchip/ksz_common.c | |
parent | 492606cdc74804d372ab1bdb8f3ef4a6fb6f9f59 (diff) |
net: dsa: microchip: ksz8863_smi: fix bulk access
Current regmap bulk access is broken, resulting to wrong reads/writes
if ksz_read64/ksz_write64 functions are used.
Mostly this issue was visible by using ksz8_fdb_dump(), which returned
corrupt MAC address.
The reason is that regmap was configured to have max_raw_read/write,
even if ksz8863_mdio_read/write functions are able to handle unlimited
read/write accesses. On ksz_read64 function we are using multiple 32bit
accesses by incrementing each access by 1 instead of 4. Resulting buffer
had 01234567.12345678 instead of 01234567.89abcdef.
We have multiple ways to fix it:
- enable 4 byte alignment for 32bit accesses. Since the HW do not have
this requirement. It will break driver.
- disable max_raw_* limit.
This patch is removing max_raw_* limit for regmap accesses in ksz8863_smi.
Fixes: 60a364760002 ("net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/microchip/ksz_common.c')
0 files changed, 0 insertions, 0 deletions