diff options
| author | David S. Miller <[email protected]> | 2018-04-27 11:53:04 -0400 | 
|---|---|---|
| committer | David S. Miller <[email protected]> | 2018-04-27 11:53:04 -0400 | 
| commit | 21fca6e01beb9cae33c7d45a69e032d91c81f07d (patch) | |
| tree | ee5924b4a53b16f813c239101935af3f480b7781 /drivers/net/dsa/dsa_loop.c | |
| parent | 834944073301e85001c3ed9913027ca47c6f889b (diff) | |
| parent | 96cbddcd52e76d9052948e408b17bedc8aa1c11a (diff) | |
Merge branch 'net-Extend-availability-of-PHY-statistics'
Florian Fainelli says:
====================
net: Extend availability of PHY statistics
This patch series adds support for retrieving PHY statistics with DSA switches
when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC).
To get there a number of things are done:
- first we move the code dealing with PHY statistics outside of net/core/ethtool.c
  and create helper functions since the same code will be reused
- then we allow network device drivers to provide an ethtool_get_phy_stats callback
  when the standard PHY library helpers are not suitable
- we update the DSA functions dealing with ethtool operations to get passed a
  stringset instead of assuming ETH_SS_STATS like they currently do
- then we provide a set of standard helpers within DSA as a framework and add
  the plumbing to allow retrieving the PHY statistics of the CPU port(s)
- finally plug support for retrieving such PHY statistics with the b53 driver
Changes in v3:
- retrict the b53 change to 539x and 531x5 series of switches
- added a change to dsa_loop.c to help test the feature
Changes in v2:
- got actual testing when the DSA master network device has a PHY that
  already provides statistics (thanks Nikita!)
- fixed the kbuild error reported when CONFIG_PHYLIB=n
- removed the checking of ops which is redundant and not needed
====================
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'drivers/net/dsa/dsa_loop.c')
| -rw-r--r-- | drivers/net/dsa/dsa_loop.c | 12 | 
1 files changed, 10 insertions, 2 deletions
| diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c index f77be9f85cb3..58f14af04639 100644 --- a/drivers/net/dsa/dsa_loop.c +++ b/drivers/net/dsa/dsa_loop.c @@ -86,16 +86,23 @@ static int dsa_loop_setup(struct dsa_switch *ds)  	return 0;  } -static int dsa_loop_get_sset_count(struct dsa_switch *ds, int port) +static int dsa_loop_get_sset_count(struct dsa_switch *ds, int port, int sset)  { +	if (sset != ETH_SS_STATS && sset != ETH_SS_PHY_STATS) +		return 0; +  	return __DSA_LOOP_CNT_MAX;  } -static void dsa_loop_get_strings(struct dsa_switch *ds, int port, uint8_t *data) +static void dsa_loop_get_strings(struct dsa_switch *ds, int port, +				 u32 stringset, uint8_t *data)  {  	struct dsa_loop_priv *ps = ds->priv;  	unsigned int i; +	if (stringset != ETH_SS_STATS && stringset != ETH_SS_PHY_STATS) +		return; +  	for (i = 0; i < __DSA_LOOP_CNT_MAX; i++)  		memcpy(data + i * ETH_GSTRING_LEN,  		       ps->ports[port].mib[i].name, ETH_GSTRING_LEN); @@ -256,6 +263,7 @@ static const struct dsa_switch_ops dsa_loop_driver = {  	.get_strings		= dsa_loop_get_strings,  	.get_ethtool_stats	= dsa_loop_get_ethtool_stats,  	.get_sset_count		= dsa_loop_get_sset_count, +	.get_ethtool_phy_stats	= dsa_loop_get_ethtool_stats,  	.phy_read		= dsa_loop_phy_read,  	.phy_write		= dsa_loop_phy_write,  	.port_bridge_join	= dsa_loop_port_bridge_join, |