diff options
author | Michal Hocko <[email protected]> | 2015-04-14 15:47:11 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2015-04-14 16:49:04 -0700 |
commit | f91e8d6d76866eafba255864ca617438cec268de (patch) | |
tree | e3e18550b6cd7d110c187c8e5947be11c99fcd55 /drivers/mtd/lpddr/lpddr_cmds.c | |
parent | 647757197cd34fae041e21af39ded00f5c346fc4 (diff) |
sparc: clarify __GFP_NOFAIL allocation
Commit 920c3ed74134 ("[SPARC64]: Add basic infrastructure for MD
add/remove notification") has added __GFP_NOFAIL for the allocation
request but it hasn't mentioned why is this strict requirement really
needed. The code was handling an allocation failure and propagated it
properly up the callchain so it is not clear why it is needed.
Dave has clarified the intention when I tried to remove the flag as not
being necessary:
: It is a serious failure.
:
: If we miss an MDESC update due to this allocation failure, the update
: is not an event which gets retransmitted so we will lose the updated
: machine description forever.
:
: We really need this allocation to succeed.
So add a comment to clarify the nofail flag and get rid of the failure
check because __GFP_NOFAIL allocation doesn't fail.
Signed-off-by: Michal Hocko <[email protected]>
Cc: David Rientjes <[email protected]>
Cc: Johannes Weiner <[email protected]>
Cc: Dave Chinner <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: Tetsuo Handa <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Vipul Pandya <[email protected]>
Cc: Jan Kara <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'drivers/mtd/lpddr/lpddr_cmds.c')
0 files changed, 0 insertions, 0 deletions