diff options
author | Benjamin Bara <[email protected]> | 2023-07-15 09:53:23 +0200 |
---|---|---|
committer | Lee Jones <[email protected]> | 2023-07-28 11:32:46 +0100 |
commit | 60466c067927abbcaff299845abd4b7069963139 (patch) | |
tree | 79d4be9c378e5192af99a639e0c1d49bb57bd37b /drivers/media/v4l2-core/v4l2-ctrls-request.c | |
parent | 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5 (diff) |
kernel/reboot: emergency_restart: Set correct system_state
As the emergency restart does not call kernel_restart_prepare(), the
system_state stays in SYSTEM_RUNNING.
Since bae1d3a05a8b, this hinders i2c_in_atomic_xfer_mode() from becoming
active, and therefore might lead to avoidable warnings in the restart
handlers, e.g.:
[ 12.667612] WARNING: CPU: 1 PID: 1 at kernel/rcu/tree_plugin.h:318 rcu_note_context_switch+0x33c/0x6b0
[ 12.676926] Voluntary context switch within RCU read-side critical section!
...
[ 12.742376] schedule_timeout from wait_for_completion_timeout+0x90/0x114
[ 12.749179] wait_for_completion_timeout from tegra_i2c_wait_completion+0x40/0x70
...
[ 12.994527] atomic_notifier_call_chain from machine_restart+0x34/0x58
[ 13.001050] machine_restart from panic+0x2a8/0x32c
Avoid these by setting the correct system_state.
Fixes: bae1d3a05a8b ("i2c: core: remove use of in_atomic()")
Cc: [email protected] # v5.2+
Reviewed-by: Dmitry Osipenko <[email protected]>
Tested-by: Nishanth Menon <[email protected]>
Signed-off-by: Benjamin Bara <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
Diffstat (limited to 'drivers/media/v4l2-core/v4l2-ctrls-request.c')
0 files changed, 0 insertions, 0 deletions