diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2023-03-16 14:55:06 +0800 |
|---|---|---|
| committer | Mike Snitzer <snitzer@kernel.org> | 2023-03-16 13:37:06 -0400 |
| commit | d3aa3e060c4a80827eb801fc448debc9daa7c46b (patch) | |
| tree | 0fab6e9f08b93e1326fef6252dc5c8a3eed49814 /drivers/md/dm.c | |
| parent | d9a02e016aaf5a57fb44e9a5e6da8ccd3b9e2e70 (diff) | |
dm stats: check for and propagate alloc_percpu failure
Check alloc_precpu()'s return value and return an error from
dm_stats_init() if it fails. Update alloc_dev() to fail if
dm_stats_init() does.
Otherwise, a NULL pointer dereference will occur in dm_stats_cleanup()
even if dm-stats isn't being actively used.
Fixes: fd2ed4d25270 ("dm: add statistics support")
Cc: stable@vger.kernel.org
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Diffstat (limited to 'drivers/md/dm.c')
| -rw-r--r-- | drivers/md/dm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index eace45a18d45..b6ace995b9ca 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2097,7 +2097,9 @@ static struct mapped_device *alloc_dev(int minor) if (!md->pending_io) goto bad; - dm_stats_init(&md->stats); + r = dm_stats_init(&md->stats); + if (r < 0) + goto bad; /* Populate the mapping, nobody knows we exist yet */ spin_lock(&_minor_lock); |