i2c: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Signed-off-by: Uwe Kleine-König <[email protected]>
Acked-by: Alain Volmat <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
Acked-by: Baruch Siach <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
Acked-by: Heiko Stuebner <[email protected]>
Acked-by: Jarkko Nikula <[email protected]>
Acked-by: Jernej Skrabec <[email protected]>
Acked-by: Jochen Friedrich <[email protected]>
Acked-by: Peter Rosin <[email protected]>
Acked-by: Vadim Pasternak <[email protected]>
Reviewed-by: Asmaa Mnebhi <[email protected]>
Reviewed-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Chris Packham <[email protected]>
Reviewed-by: Chris Pringle <[email protected]>
Reviewed-by: Claudiu Beznea <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Hans de Goede <[email protected]>
Reviewed-by: Jean Delvare <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Linus Walleij <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
Reviewed-by: Patrice Chotard <[email protected]>
Reviewed-by: Tali Perry <[email protected]>
Reviewed-by: Vignesh Raghavendra <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index d1c59d83a65b..e897d9101434 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -2309,7 +2309,7 @@ clk_free:
 	return ret;
 }
 
-static int stm32f7_i2c_remove(struct platform_device *pdev)
+static void stm32f7_i2c_remove(struct platform_device *pdev)
 {
 	struct stm32f7_i2c_dev *i2c_dev = platform_get_drvdata(pdev);
 
@@ -2341,8 +2341,6 @@ static int stm32f7_i2c_remove(struct platform_device *pdev)
 	stm32f7_i2c_write_fm_plus_bits(i2c_dev, false);
 
 	clk_disable_unprepare(i2c_dev->clk);
-
-	return 0;
 }
 
 static int __maybe_unused stm32f7_i2c_runtime_suspend(struct device *dev)
@@ -2486,7 +2484,7 @@ static struct platform_driver stm32f7_i2c_driver = {
 		.pm = &stm32f7_i2c_pm_ops,
 	},
 	.probe = stm32f7_i2c_probe,
-	.remove = stm32f7_i2c_remove,
+	.remove_new = stm32f7_i2c_remove,
 };
 
 module_platform_driver(stm32f7_i2c_driver);