aboutsummaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
diff options
context:
space:
mode:
authorBoris Brezillon <boris.brezillon@bootlin.com>2018-11-15 11:58:51 +0100
committerBoris Brezillon <boris.brezillon@bootlin.com>2018-11-15 17:56:45 +0100
commit5a43911fd256f1c9748f3f82aee1c3a3adad2719 (patch)
tree3825ed6f831559715d83aa0632de02775a983bb0 /drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
parentadf59dd2408c4536d490bee649784f0465562444 (diff)
drm/vc4: Fix NULL pointer dereference in the async update path
vc4_plane_atomic_async_update() calls vc4_plane_atomic_check() which in turn calls vc4_plane_setup_clipping_and_scaling(), and since commit 58a6a36fe8e0 ("drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic"), this function accesses plane_state->state which will be NULL when called from the async update path because we're passing the current plane state, and plane_state->state has been assigned to NULL in drm_atomic_helper_swap_state(). Pass the new state instead of the current one (the new state has ->state set to a non-NULL value). Fixes: 58a6a36fe8e0 ("drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic") Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Reviewed-by: Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20181115105852.9844-1-boris.brezillon@bootlin.com
Diffstat (limited to 'drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c')
0 files changed, 0 insertions, 0 deletions