diff options
author | Matthew Auld <matthew.auld@intel.com> | 2022-08-05 14:22:40 +0100 |
---|---|---|
committer | Matthew Auld <matthew.auld@intel.com> | 2022-08-09 11:36:51 +0100 |
commit | 8676145eb2f53a9940ff70910caf0125bd8a4bc2 (patch) | |
tree | 486be06aa8b53890d7aa93999b8bbceaf34cbf5a /drivers/gpu/drm/logicvc/logicvc_layer.c | |
parent | dba4d442be8c4d41d3e1ee4f72a2cd8fa524b8cb (diff) |
drm/i915/ttm: fix CCS handling
Crucible + recent Mesa seems to sometimes hit:
GEM_BUG_ON(num_ccs_blks > NUM_CCS_BLKS_PER_XFER)
And it looks like we can also trigger this with gem_lmem_swapping, if we
modify the test to use slightly larger object sizes.
Looking closer it looks like we have the following issues in
migrate_copy():
- We are using plain integer in various places, which we can easily
overflow with a large object.
- We pass the entire object size (when the src is lmem) into
emit_pte() and then try to copy it, which doesn't work, since we
only have a few fixed sized windows in which to map the pages and
perform the copy. With an object > 8M we therefore aren't properly
copying the pages. And then with an object > 64M we trigger the
GEM_BUG_ON(num_ccs_blks > NUM_CCS_BLKS_PER_XFER).
So it looks like our copy handling for any object > 8M (which is our
CHUNK_SZ) is currently broken on DG2.
Fixes: da0595ae91da ("drm/i915/migrate: Evict and restore the flatccs capable lmem obj")
Testcase: igt@gem_lmem_swapping
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Ramalingam C<ramalingam.c@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220805132240.442747-2-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/logicvc/logicvc_layer.c')
0 files changed, 0 insertions, 0 deletions