diff options
author | Alan Previn <[email protected]> | 2023-02-23 16:17:58 -0800 |
---|---|---|
committer | John Harrison <[email protected]> | 2023-03-02 17:13:59 -0800 |
commit | 0591bdad58c4b83a286872305e748bfd77d16d28 (patch) | |
tree | 2a9fbc367267b1cade0403c6bf58307eff41fa22 /drivers/gpu/drm/i915/selftests/i915_request.c | |
parent | 3cba09a6ac86ea1d456909626eb2685596c07822 (diff) |
drm/i915/gsc: Fix the Driver-FLR completion
The Driver-FLR flow may inadvertently exit early before the full
completion of the re-init of the internal HW state if we only poll
GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead
we need a two-step completion wait-for-completion flow that also
involves GU_CNTL. See the patch and new code comments for detail.
This is new direction from HW architecture folks.
v2: - Add error message for the teardown timeout (Anshuman)
- Don't duplicate code in comments (Jani)
v3: - Add get/put runtime-pm for this function. Though
not functionally required during unload, its so the uncore
doesn't complain.
v4: - Remove the get/put runtime-pm - that was for a prior
version of this patch (not needed for drm-managed callback).
- Remove the fixes tag since this is only for MTL and MTL
still needs force probe (Daniele).
- Bit 31 of GU_CNTL should be DRIVERFLR instead of
DRIVERFLR_STATUS (Daniele).
Signed-off-by: Alan Previn <[email protected]>
Tested-by: Vinay Belgaumkar <[email protected]>
Reviewed-by: Daniele Ceraolo Spurio <[email protected]>
Signed-off-by: John Harrison <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/i915/selftests/i915_request.c')
0 files changed, 0 insertions, 0 deletions