diff options
| author | Ondrej Jirman <megous@megous.com> | 2018-03-10 12:05:11 +0100 |
|---|---|---|
| committer | Maxime Ripard <maxime.ripard@bootlin.com> | 2018-03-12 10:07:17 +0100 |
| commit | 7035046d6d02d455325c5d0328bcc8a0b5dd96b0 (patch) | |
| tree | 636eb6ac5d2643b3a16c1856832791cc1e76599b /drivers/gpu/drm/drm_framebuffer.c | |
| parent | b0655d668fc4faf0c1985e828820f9b9ca13abe6 (diff) | |
drm/sun4i: Fix exclusivity of the TCON clocks
Currently the exclusivity is enabled when the rate is set by
the mode setting functions. These functions are called by
mode_set_nofb callback of drm_crc_helper. Then exclusivity
is disabled when tcon is disabled by atomic_disable
callback.
What happens is that mode_set_nofb can be called once when
mode changes, and afterwards the system can call atomic_enable
and atomic_disable multiple times without further calls to
mode_set_nofb.
This happens:
mode_set_nofb - clk exclusivity is enabled
atomic_enable
atomic_disable - clk exclusivity is disabled
atomic_enable
atomic_disable - clk exclusivity is already disabled, leading to WARN
in clk_rate_exclusive_put
Solution is to enable exclusivity in sun4i_tcon_channel_set_status.
Signed-off-by: Ondrej Jirman <megous@megous.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180310110511.14697-1-megous@megous.com
Diffstat (limited to 'drivers/gpu/drm/drm_framebuffer.c')
0 files changed, 0 insertions, 0 deletions