diff options
author | Srinivasan Shanmugam <[email protected]> | 2024-05-10 15:25:47 +0530 |
---|---|---|
committer | Alex Deucher <[email protected]> | 2024-05-23 15:11:19 -0400 |
commit | 0b6dc64b4e2254a8aa6318116f684ffb440a6e4c (patch) | |
tree | bb99ab6311dcf6a654e2678012d74feae0ef7ce8 /drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | |
parent | cf85764e2bf1acbefb45e09919a8e9fafc58e119 (diff) |
drm/amd/display: Refactor construct_phy function in dc/link/link_factory.c
This commit modifies the construct_phy function to handle the case where
`bios->integrated_info` is NULL and to address a compiler warning about
a large stack allocation.
Upon examination, it was found that the local `integrated_info`
structure was just used to copy values which is large and was being
declared directly on the stack which could potentially lead to
performance issues. This commit changes the code to use
`bios->integrated_info` directly, which avoids the need for a large
stack allocation.
The function now checks if `bios->integrated_info` is NULL before
entering a for loop that uses it. If `bios->integrated_info` is NULL,
the function skips the for loop and continues executing the rest of the
code. This ensures that the function behaves correctly when
`bios->integrated_info` is NULL and improves compatibility with dGPUs.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c: In function ‘construct_phy’:
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_factory.c:743:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Cc: Wenjing Liu <[email protected]>
Cc: Jerry Zuo <[email protected]>
Cc: Qingqing Zhuo <[email protected]>
Cc: Tom Chung <[email protected]>
Cc: Alvin Lee <[email protected]>
Cc: Rodrigo Siqueira <[email protected]>
Cc: Roman Li <[email protected]>
Cc: Hersen Wu <[email protected]>
Cc: Alex Hung <[email protected]>
Cc: Aurabindo Pillai <[email protected]>
Cc: Harry Wentland <[email protected]>
Signed-off-by: Srinivasan Shanmugam <[email protected]>
Suggested-by: Wenjing Liu <[email protected]>
Reviewed-by: Wenjing Liu <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c')
0 files changed, 0 insertions, 0 deletions