diff options
| author | Armin Wolf <W_Armin@gmx.de> | 2024-01-03 20:27:04 +0100 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2024-01-22 11:34:30 +0100 |
| commit | 6ba7843b59b77360812617d071313c7f35f3757a (patch) | |
| tree | 2b8670a142cbe30af8b8f7d878a94151c4cfd800 /drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | |
| parent | 6613476e225e090cc9aad49be7fa504e290dd33d (diff) | |
platform/x86: wmi: Fix error handling in legacy WMI notify handler functions
When wmi_install_notify_handler()/wmi_remove_notify_handler() are
unable to enable/disable the WMI device, they unconditionally return
an error to the caller.
When registering legacy WMI notify handlers, this means that the
callback remains registered despite wmi_install_notify_handler()
having returned an error.
When removing legacy WMI notify handlers, this means that the
callback is removed despite wmi_remove_notify_handler() having
returned an error.
Fix this by only warning when the WMI device could not be enabled.
This behaviour matches the bus-based WMI interface.
Tested on a Dell Inspiron 3505 and a Acer Aspire E1-731.
Fixes: 58f6425eb92f ("WMI: Cater for multiple events with same GUID")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240103192707.115512-2-W_Armin@gmx.de
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c')
0 files changed, 0 insertions, 0 deletions