diff options
author | Konrad Dybcio <konrad.dybcio@linaro.org> | 2024-06-25 20:54:41 +0200 |
---|---|---|
committer | Rob Clark <robdclark@chromium.org> | 2024-06-29 13:45:30 -0700 |
commit | 43ec1a202cfa9f765412d325b93873284e7c3d82 (patch) | |
tree | 26831e1233667e2a121c9d246be8b42758332404 /drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | |
parent | 1e210f462b367ccf9589110f33e5350f53c7ec96 (diff) |
drm/msm/adreno: De-spaghettify the use of memory barriers
Memory barriers help ensure instruction ordering, NOT time and order
of actual write arrival at other observers (e.g. memory-mapped IP).
On architectures employing weak memory ordering, the latter can be a
giant pain point, and it has been as part of this driver.
Moreover, the gpu_/gmu_ accessors already use non-relaxed versions of
readl/writel, which include r/w (respectively) barriers.
Replace the barriers with a readback (or drop altogether where possible)
that ensures the previous writes have exited the write buffer (as the CPU
must flush the write to the register it's trying to read back).
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/600869/
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c')
0 files changed, 0 insertions, 0 deletions