diff options
| author | Xiyu Yang <[email protected]> | 2020-04-23 13:09:27 +0800 |
|---|---|---|
| committer | Theodore Ts'o <[email protected]> | 2020-06-03 23:16:49 -0400 |
| commit | 3bbd0ef26098d241dc59ee77ba14b7dab0df0786 (patch) | |
| tree | c814fdd1ca7e627a43f182703f949a741014d8a7 /drivers/fpga/fpga-mgr.c | |
| parent | c36a71b4e35ab35340facdd6964a00956b9fef0a (diff) | |
ext4: fix buffer_head refcnt leak when ext4_iget() fails
ext4_orphan_get() invokes ext4_read_inode_bitmap(), which returns a
reference of the specified buffer_head object to "bitmap_bh" with
increased refcnt.
When ext4_orphan_get() returns, local variable "bitmap_bh" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
ext4_orphan_get(). When ext4_iget() fails, the function forgets to
decrease the refcnt increased by ext4_read_inode_bitmap(), causing a
refcnt leak.
Fix this issue by calling brelse() when ext4_iget() fails.
Signed-off-by: Xiyu Yang <[email protected]>
Signed-off-by: Xin Tan <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Theodore Ts'o <[email protected]>
Diffstat (limited to 'drivers/fpga/fpga-mgr.c')
0 files changed, 0 insertions, 0 deletions