diff options
| author | Nadav Amit <[email protected]> | 2022-07-11 09:59:06 -0700 |
|---|---|---|
| committer | akpm <[email protected]> | 2022-07-26 18:25:01 -0700 |
| commit | d172b1a3bd065dd89234eac547fc62cf80681631 (patch) | |
| tree | 6e7a6d1a112a50d3607adcbd9787f2a08fe366ae /drivers/fpga/fpga-bridge.c | |
| parent | c80af0c250c8f8a3c978aa5aafbe9c39b336b813 (diff) | |
userfaultfd: provide properly masked address for huge-pages
Commit 824ddc601adc ("userfaultfd: provide unmasked address on
page-fault") was introduced to fix an old bug, in which the offset in the
address of a page-fault was masked. Concerns were raised - although were
never backed by actual code - that some userspace code might break because
the bug has been around for quite a while. To address these concerns a
new flag was introduced, and only when this flag is set by the user,
userfaultfd provides the exact address of the page-fault.
The commit however had a bug, and if the flag is unset, the offset was
always masked based on a base-page granularity. Yet, for huge-pages, the
behavior prior to the commit was that the address is masked to the
huge-page granulrity.
While there are no reports on real breakage, fix this issue. If the flag
is unset, use the address with the masking that was done before.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 824ddc601adc ("userfaultfd: provide unmasked address on page-fault")
Signed-off-by: Nadav Amit <[email protected]>
Reported-by: James Houghton <[email protected]>
Reviewed-by: Mike Rapoport <[email protected]>
Reviewed-by: Peter Xu <[email protected]>
Reviewed-by: James Houghton <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Andrea Arcangeli <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'drivers/fpga/fpga-bridge.c')
0 files changed, 0 insertions, 0 deletions