diff options
author | Jiri Slaby (SUSE) <[email protected]> | 2024-08-05 12:20:36 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2024-08-07 13:13:35 +0200 |
commit | d0009a32c9e4e083358092f3c97e3c6e803a8930 (patch) | |
tree | 507cb404cdae4bdcedc091eba92a944843444c8f /drivers/fpga/fpga-bridge.c | |
parent | 602babaa84d627923713acaf5f7e9a4369e77473 (diff) |
serial: don't use uninitialized value in uart_poll_init()
Coverity reports (as CID 1536978) that uart_poll_init() passes
uninitialized pm_state to uart_change_pm(). It is in case the first 'if'
takes the true branch (does "goto out;").
Fix this and simplify the function by simple guard(mutex). The code
needs no labels after this at all. And it is pretty clear that the code
has not fiddled with pm_state at that point.
Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
Fixes: 5e227ef2aa38 (serial: uart_poll_init() should power on the UART)
Cc: [email protected]
Cc: Douglas Anderson <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
Reviewed-by: Douglas Anderson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'drivers/fpga/fpga-bridge.c')
0 files changed, 0 insertions, 0 deletions