diff options
author | Konrad Dybcio <[email protected]> | 2023-03-08 22:40:07 +0100 |
---|---|---|
committer | Georgi Djakov <[email protected]> | 2023-04-05 11:29:59 +0300 |
commit | 1d779317eb6529d89bfe6d7900a2cf9e03149aeb (patch) | |
tree | 2674600b402d7f95aa5a92772ee1dffbc7be323e /drivers/fpga/fpga-bridge.c | |
parent | 72b2720c18ecde92e6a36c4ac897dd5848e3f379 (diff) |
interconnect: qcom: rpm: make QoS INVALID default
Currently NOC_QOS_MODE_FIXED is defined as 0x0 which makes it the
default option (partial struct initialization). The default option
however should be NOC_QOS_MODE_INVALID.
That results in bogus QoS configurations being sent for port 0 (which
is used for the DRAM endpoint on BIMC, for example) coming from all nodes
with .qos.ap_owned = true and uninitialized .qos.qos_mode. It's also an
issue for newer SoCs where all nodes are treated as if they were ap_owned,
but not all of them have QoS configuration.
The NOC_QOS_MODEs are defined as preprocessor constants and are not used
anywhere outside qcom_icc_set_noc_qos(), which is easily worked around.
Separate the desc->type values from the values sent to msmbus in the
aforementioned function. Make the former an enum for better mainainability.
Signed-off-by: Konrad Dybcio <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Georgi Djakov <[email protected]>
Diffstat (limited to 'drivers/fpga/fpga-bridge.c')
0 files changed, 0 insertions, 0 deletions