aboutsummaryrefslogtreecommitdiff
path: root/drivers/clocksource/timer-stm32.c
diff options
context:
space:
mode:
authorBoqun Feng <[email protected]>2017-08-24 22:22:36 +0800
committerIngo Molnar <[email protected]>2017-08-29 15:14:38 +0200
commit1c322ac06d9af7ea259098ae5dc977855207d335 (patch)
tree7b2e3106308a5e8211826caab2f01618a555590d /drivers/clocksource/timer-stm32.c
parent34d54f3d6917f519693dbe873ee59cd06fb515ed (diff)
acpi/nfit: Fix COMPLETION_INITIALIZER_ONSTACK() abuse
COMPLETION_INITIALIZER_ONSTACK() is supposed to be used as an initializer, in other words, it should only be used in assignment expressions or compound literals. So the usage in drivers/acpi/nfit/core.c: COMPLETION_INITIALIZER_ONSTACK(flush.cmp); ... is inappropriate. Besides, this usage could also break the build for another fix that reduces stack sizes caused by COMPLETION_INITIALIZER_ONSTACK(), because that fix changes COMPLETION_INITIALIZER_ONSTACK() from rvalue to lvalue, and usage as above will report the following error: drivers/acpi/nfit/core.c: In function 'acpi_nfit_flush_probe': include/linux/completion.h:77:3: error: value computed is not used [-Werror=unused-value] (*({ init_completion(&work); &work; })) This patch fixes this by replacing COMPLETION_INITIALIZER_ONSTACK() with init_completion() in acpi_nfit_flush_probe(), which does the same initialization without any other problems. Signed-off-by: Boqun Feng <[email protected]> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> Acked-by: Dan Williams <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Cc: Andrew Morton <[email protected]> Cc: Byungchul Park <[email protected]> Cc: Len Brown <[email protected]> Cc: Linus Torvalds <[email protected]> Cc: Nicholas Piggin <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: [email protected] Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'drivers/clocksource/timer-stm32.c')
0 files changed, 0 insertions, 0 deletions