aboutsummaryrefslogtreecommitdiff
path: root/drivers/base/firmware_loader/main.c
diff options
context:
space:
mode:
authorPierre Gondois <[email protected]>2023-04-14 10:14:49 +0200
committerSudeep Holla <[email protected]>2023-04-14 10:13:38 +0100
commit7a306e3eabf2b2fd8cffa69b87b32dbf814d79ce (patch)
tree399f075ff94d390091eac2fe8cf83c7c5d2495e2 /drivers/base/firmware_loader/main.c
parente103d55465db06c5344201fd5fa11bb19bc479c5 (diff)
cacheinfo: Check sib_leaf in cache_leaves_are_shared()
If there is no ACPI/DT information, it is assumed that L1 caches are private and L2 (and higher) caches are shared. A cache is 'shared' between two CPUs if it is accessible from these two CPUs. Each CPU owns a representation (i.e. has a dedicated cacheinfo struct) of the caches it has access to. cache_leaves_are_shared() tries to identify whether two representations are designating the same actual cache. In cache_leaves_are_shared(), if 'this_leaf' is a L2 cache (or higher) and 'sib_leaf' is a L1 cache, the caches are detected as shared as only this_leaf's cache level is checked. This is leads to setting sib_leaf as being shared with another CPU, which is incorrect as this is a L1 cache. Check 'sib_leaf->level'. Also update the comment as the function is called when populating 'shared_cpu_map'. Fixes: f16d1becf96f ("cacheinfo: Use cache identifiers to check if the caches are shared if available") Signed-off-by: Pierre Gondois <[email protected]> Reviewed-by: Conor Dooley <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Sudeep Holla <[email protected]>
Diffstat (limited to 'drivers/base/firmware_loader/main.c')
0 files changed, 0 insertions, 0 deletions