diff options
| author | James Morse <james.morse@arm.com> | 2021-08-11 16:38:31 +0000 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2021-08-11 18:42:53 +0200 |
| commit | 111136e69c9df50c3ca7d4e3977344b8a2d0d947 (patch) | |
| tree | ec4d79b3c0b13a94b278fb2bead57011056476ae /arch/x86/kernel/cpu/resctrl/ctrlmondata.c | |
| parent | 5c3b63cdba441c6a530b974ff73b14161d96a0c3 (diff) | |
x86/resctrl: Make resctrl_arch_get_config() return its value
resctrl_arch_get_config() has no return, but does pass a single value
back via one of its arguments.
Return the value instead.
Suggested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20210811163831.14917-1-james.morse@arm.com
Diffstat (limited to 'arch/x86/kernel/cpu/resctrl/ctrlmondata.c')
| -rw-r--r-- | arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c index a487cf7ff04e..87666275eed9 100644 --- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c +++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c @@ -427,16 +427,15 @@ out: return ret ?: nbytes; } -void resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, - u32 closid, enum resctrl_conf_type type, u32 *value) +u32 resctrl_arch_get_config(struct rdt_resource *r, struct rdt_domain *d, + u32 closid, enum resctrl_conf_type type) { struct rdt_hw_domain *hw_dom = resctrl_to_arch_dom(d); u32 idx = get_config_index(closid, type); if (!is_mba_sc(r)) - *value = hw_dom->ctrl_val[idx]; - else - *value = hw_dom->mbps_val[idx]; + return hw_dom->ctrl_val[idx]; + return hw_dom->mbps_val[idx]; } static void show_doms(struct seq_file *s, struct resctrl_schema *schema, int closid) @@ -451,8 +450,8 @@ static void show_doms(struct seq_file *s, struct resctrl_schema *schema, int clo if (sep) seq_puts(s, ";"); - resctrl_arch_get_config(r, dom, closid, schema->conf_type, - &ctrl_val); + ctrl_val = resctrl_arch_get_config(r, dom, closid, + schema->conf_type); seq_printf(s, r->format_str, dom->id, max_data_width, ctrl_val); sep = true; |