diff options
author | Julia Lawall <Julia.Lawall@inria.fr> | 2020-07-26 12:58:32 +0200 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2020-08-14 18:05:06 +0300 |
commit | 18c25b4019caa94deee67e839aea6b7b626e70d5 (patch) | |
tree | c527219f8a1e06dc838cf87f9c1b005f06da3a03 /arch/sparc | |
parent | 221af8135478939eaedf1f558aea32e08e05ae65 (diff) |
ath: drop unnecessary list_empty
list_for_each_entry{_safe} is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.
Note that list_for_each_entry{_safe} is defined in terms of
list_first_entry, which indicates that it should not be used on an
empty list. But in list_for_each_entry{_safe}, the element obtained
by list_first_entry is not really accessed, only the address of its
list_head field is compared to the address of the list head, so the
list_first_entry is safe.
The semantic patch that makes this change for the list_for_each_entry
case is as follows: (http://coccinelle.lip6.fr/)
<smpl>
@@
expression x,e;
statement S;
identifier i;
@@
-if (!(list_empty(x)))
list_for_each_entry(i,x,...) S
... when != i
? i = e
</smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1595761112-11003-8-git-send-email-Julia.Lawall@inria.fr
Diffstat (limited to 'arch/sparc')
0 files changed, 0 insertions, 0 deletions