diff options
author | daniel.starke@siemens.com <daniel.starke@siemens.com> | 2022-02-17 23:31:22 -0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-21 19:51:04 +0100 |
commit | 687f9ad43c52501f46164758e908a5dd181a87fc (patch) | |
tree | bda22305006ff19bd9a8bcc6ddc859529a809013 /arch/s390/lib/test_modules_helpers.c | |
parent | c19d93542a6081577e6da9bf5e887979c72e80c1 (diff) |
tty: n_gsm: fix wrong modem processing in convergence layer type 2
The function gsm_process_modem() exists to handle modem status bits of
incoming frames. This includes incoming MSC (modem status command) frames
and convergence layer type 2 data frames. The function, however, was only
designed to handle MSC frames as it expects the command length. Within
gsm_dlci_data() it is wrongly assumed that this is the same as the data
frame length. This is only true if the data frame contains only 1 byte of
payload.
This patch names the length parameter of gsm_process_modem() in a generic
manner to reflect its association. It also corrects all calls to the
function to handle the variable number of modem status octets correctly in
both cases.
Fixes: 7263287af93d ("tty: n_gsm: Fixed logic to decode break signal from modem status")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220218073123.2121-6-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'arch/s390/lib/test_modules_helpers.c')
0 files changed, 0 insertions, 0 deletions