diff options
author | Josef Bacik <[email protected]> | 2021-01-14 14:02:46 -0500 |
---|---|---|
committer | David Sterba <[email protected]> | 2021-02-08 22:58:56 +0100 |
commit | 867ed321f90d06aaba84e2c91de51cd3038825ef (patch) | |
tree | 9bb5d3a9dbac4961a6d09e2dc8458cae3c4ab1c1 /arch/powerpc/lib/code-patching.c | |
parent | eddda68d97732ce05ca145f8e85e8a447f65cdad (diff) |
btrfs: abort the transaction if we fail to inc ref in btrfs_copy_root
While testing my error handling patches, I added a error injection site
at btrfs_inc_extent_ref, to validate the error handling I added was
doing the correct thing. However I hit a pretty ugly corruption while
doing this check, with the following error injection stack trace:
btrfs_inc_extent_ref
btrfs_copy_root
create_reloc_root
btrfs_init_reloc_root
btrfs_record_root_in_trans
btrfs_start_transaction
btrfs_update_inode
btrfs_update_time
touch_atime
file_accessed
btrfs_file_mmap
This is because we do not catch the error from btrfs_inc_extent_ref,
which in practice would be ENOMEM, which means we lose the extent
references for a root that has already been allocated and inserted,
which is the problem. Fix this by aborting the transaction if we fail
to do the reference modification.
CC: [email protected] # 4.4+
Signed-off-by: Josef Bacik <[email protected]>
Reviewed-by: David Sterba <[email protected]>
Signed-off-by: David Sterba <[email protected]>
Diffstat (limited to 'arch/powerpc/lib/code-patching.c')
0 files changed, 0 insertions, 0 deletions