diff options
author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-05-05 12:30:01 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2010-05-19 12:59:16 -0300 |
commit | 64561a38838c66de1af059e7f4c14bbaa7dd3d54 (patch) | |
tree | f80efbbca61c8d5055d4be26d9295fb3fee564b6 /arch/m32r/lib/memset.S | |
parent | e36309f54a6196792fce74100356ebdeaecabd56 (diff) |
V4L/DVB: Fix unlock logic at medusa_video_init
As reported by Dan Carpenter:
> This was my patch: "cx25821: fix double unlock in medusa_video_init()"
>
> It accidentally got merged two times. The version from the staging tree
> is not correct. Please can you revert it:
> 7a02f549fcc30fe6be0c0024beae9a3db22e1af6 "Staging: cx25821: fix double
> unlock in medusa_video_init()"
After reviewing the logic at the function, instead of just adding a patch to
revert the wrong one, the better is to apply a different logic: add a goto
that will always unlock and return the error.
This simplifies the code a little bit, and, instead of just return -EINVAL,
it will return the error condition reported by the called functions.
This patch is folded with another patch from Dan that added one missing
goto.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'arch/m32r/lib/memset.S')
0 files changed, 0 insertions, 0 deletions