diff options
| author | Eric DeVolder <[email protected]> | 2023-03-27 15:10:26 -0400 |
|---|---|---|
| committer | Borislav Petkov (AMD) <[email protected]> | 2023-03-30 11:07:30 +0200 |
| commit | fed8d8773b8ea68ad99d9eee8c8343bef9da2c2c (patch) | |
| tree | ffcf0dc62541c18dc48856e67c114988fad93b12 | |
| parent | a74fabfbd1b7013045afc8cc541e6cab3360ccb5 (diff) | |
x86/acpi/boot: Correct acpi_is_processor_usable() check
The logic in acpi_is_processor_usable() requires the online capable
bit be set for hotpluggable CPUs. The online capable bit has been
introduced in ACPI 6.3.
However, for ACPI revisions < 6.3 which do not support that bit, CPUs
should be reported as usable, not the other way around.
Reverse the check.
[ bp: Rewrite commit message. ]
Fixes: e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC")
Suggested-by: Miguel Luis <[email protected]>
Suggested-by: Boris Ostrovsky <[email protected]>
Signed-off-by: Eric DeVolder <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Tested-by: David R <[email protected]>
Cc: <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
| -rw-r--r-- | arch/x86/kernel/acpi/boot.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 729218462404..0dac4ab5b55b 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -197,7 +197,8 @@ static bool __init acpi_is_processor_usable(u32 lapic_flags) if (lapic_flags & ACPI_MADT_ENABLED) return true; - if (acpi_support_online_capable && (lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) + if (!acpi_support_online_capable || + (lapic_flags & ACPI_MADT_ONLINE_CAPABLE)) return true; return false; |