aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikita Zhandarovich <[email protected]>2024-01-12 05:42:26 -0800
committerHans Verkuil <[email protected]>2024-02-05 12:57:44 +0100
commitfd61d77a3d28444b2635f0c8b5a2ecd6a4d94026 (patch)
treea80f0a65860dd3575555dbb7468fbb698d0a6b65
parent8b9911e553e762ebbe626270ce11b008736f1848 (diff)
media: em28xx: annotate unchecked call to media_device_register()
Static analyzers generate alerts for an unchecked call to `media_device_register()`. However, in this case, the device will work reliably without the media controller API. Add a comment above the call to prevent future unnecessary changes. Suggested-by: Mauro Carvalho Chehab <[email protected]> Fixes: 37ecc7b1278f ("[media] em28xx: add media controller support") Signed-off-by: Nikita Zhandarovich <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
-rw-r--r--drivers/media/usb/em28xx/em28xx-cards.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index 4d037c92af7c..bae76023cf71 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -4094,6 +4094,10 @@ static int em28xx_usb_probe(struct usb_interface *intf,
* topology will likely change after the load of the em28xx subdrivers.
*/
#ifdef CONFIG_MEDIA_CONTROLLER
+ /*
+ * No need to check the return value, the device will still be
+ * usable without media controller API.
+ */
retval = media_device_register(dev->media_dev);
#endif