diff options
| author | tangzhenhao <[email protected]> | 2020-11-29 23:23:56 -0800 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2020-12-08 10:02:45 -0700 |
| commit | f87905660ed01d85e45eac22d479f31f380b2f50 (patch) | |
| tree | f7921a5f4b1fde5a573a0f91e91b4f2c096bb344 | |
| parent | eebf34a85c8c724676eba502d15202854f199b05 (diff) | |
drivers/lightnvm: fix a null-ptr-deref bug in pblk-core.c
At line 294 in drivers/lightnvm/pblk-write.c, function pblk_gen_run_ws is
called with actual param GFP_ATOMIC. pblk_gen_run_ws call mempool_alloc
using "GFP_ATOMIC" flag, so mempool_alloc can return null. So we need to
check the return-val of mempool_alloc to avoid null-ptr-deref bug.
Signed-off-by: tangzhenhao <[email protected]>
Reviewed-by: Matias Bjørling <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
| -rw-r--r-- | drivers/lightnvm/pblk-core.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index 97c68731406b..1dddba11e721 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -1869,6 +1869,10 @@ void pblk_gen_run_ws(struct pblk *pblk, struct pblk_line *line, void *priv, struct pblk_line_ws *line_ws; line_ws = mempool_alloc(&pblk->gen_ws_pool, gfp_mask); + if (!line_ws) { + pblk_err(pblk, "pblk: could not allocate memory\n"); + return; + } line_ws->pblk = pblk; line_ws->line = line; |