diff options
| author | Thinh Nguyen <[email protected]> | 2022-10-25 15:10:14 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2022-10-26 18:31:55 +0200 |
| commit | f78961f8380b940e0cfc7e549336c21a2ad44f4d (patch) | |
| tree | a78e305fd85ef46c7a45f92e1512b59cac682033 | |
| parent | 88c8e05ed5c0f05a637e654bbe4e49a1ebe7013c (diff) | |
usb: dwc3: gadget: Stop processing more requests on IMI
When servicing a transfer completion event, the dwc3 driver will reclaim
TRBs of started requests up to the request associated with the interrupt
event. Currently we don't check for interrupt due to missed isoc, and
the driver may attempt to reclaim TRBs beyond the associated event. This
causes invalid memory access when the hardware still owns the TRB. If
there's a missed isoc TRB with IMI (interrupt on missed isoc), make sure
to stop servicing further.
Note that only the last TRB of chained TRBs has its status updated with
missed isoc.
Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
Cc: [email protected]
Reported-by: Jeff Vanhoof <[email protected]>
Reported-by: Dan Vacura <[email protected]>
Signed-off-by: Thinh Nguyen <[email protected]>
Reviewed-by: Jeff Vanhoof <[email protected]>
Tested-by: Jeff Vanhoof <[email protected]>
Link: https://lore.kernel.org/r/b29acbeab531b666095dfdafd8cb5c7654fbb3e1.1666735451.git.Thinh.Nguyen@synopsys.com
Signed-off-by: Greg Kroah-Hartman <[email protected]>
| -rw-r--r-- | drivers/usb/dwc3/gadget.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index dd8ecbe61bec..230b3c660054 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -3248,6 +3248,10 @@ static int dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep, if (event->status & DEPEVT_STATUS_SHORT && !chain) return 1; + if ((trb->ctrl & DWC3_TRB_CTRL_ISP_IMI) && + DWC3_TRB_SIZE_TRBSTS(trb->size) == DWC3_TRBSTS_MISSED_ISOC) + return 1; + if ((trb->ctrl & DWC3_TRB_CTRL_IOC) || (trb->ctrl & DWC3_TRB_CTRL_LST)) return 1; |