aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArtem Chernyshev <[email protected]>2023-11-28 14:10:08 +0300
committerMartin K. Petersen <[email protected]>2023-12-05 21:01:52 -0500
commitf5f27a332a14f43463aa0075efa3a0c662c0f4a8 (patch)
treee5016cd051de591cb546739c2658e62316185d7f
parentaf85d689ae08860e4f9648f05e09f1de868091f4 (diff)
scsi: fnic: Return error if vmalloc() failed
In fnic_init_module() exists redundant check for return value from fnic_debugfs_init(), because at moment it only can return zero. It make sense to process theoretical vmalloc() failure. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 9730ddfb123d ("scsi: fnic: remove redundant assignment of variable rc") Signed-off-by: Artem Chernyshev <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Karan Tilak Kumar <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
-rw-r--r--drivers/scsi/fnic/fnic_debugfs.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c
index c4d9ed0d7d75..2619a2d4f5f1 100644
--- a/drivers/scsi/fnic/fnic_debugfs.c
+++ b/drivers/scsi/fnic/fnic_debugfs.c
@@ -52,9 +52,10 @@ int fnic_debugfs_init(void)
fc_trc_flag->fnic_trace = 2;
fc_trc_flag->fc_trace = 3;
fc_trc_flag->fc_clear = 4;
+ return 0;
}
- return 0;
+ return -ENOMEM;
}
/*