diff options
| author | Taehee Yoo <[email protected]> | 2018-10-24 20:15:17 +0900 |
|---|---|---|
| committer | Daniel Borkmann <[email protected]> | 2018-10-26 00:32:21 +0200 |
| commit | f592f804831f1cf9d1f9966f58c80f150e6829b5 (patch) | |
| tree | 1b4368acf0867c3ace26466ee8b44e20755acf34 | |
| parent | 42d0f71c9b5fd48861d61cfc05c9e001f847c9d5 (diff) | |
bpf: devmap: fix wrong interface selection in notifier_call
The dev_map_notification() removes interface in devmap if
unregistering interface's ifindex is same.
But only checking ifindex is not enough because other netns can have
same ifindex. so that wrong interface selection could occurred.
Hence netdev pointer comparison code is added.
v2: compare netdev pointer instead of using net_eq() (Daniel Borkmann)
v1: Initial patch
Fixes: 2ddf71e23cc2 ("net: add notifier hooks for devmap bpf map")
Signed-off-by: Taehee Yoo <[email protected]>
Acked-by: Song Liu <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
| -rw-r--r-- | kernel/bpf/devmap.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c index 141710b82a6c..191b79948424 100644 --- a/kernel/bpf/devmap.c +++ b/kernel/bpf/devmap.c @@ -512,8 +512,7 @@ static int dev_map_notification(struct notifier_block *notifier, struct bpf_dtab_netdev *dev, *odev; dev = READ_ONCE(dtab->netdev_map[i]); - if (!dev || - dev->dev->ifindex != netdev->ifindex) + if (!dev || netdev != dev->dev) continue; odev = cmpxchg(&dtab->netdev_map[i], dev, NULL); if (dev == odev) |