diff options
| author | Robin Murphy <[email protected]> | 2024-09-04 19:41:55 +0100 |
|---|---|---|
| committer | Will Deacon <[email protected]> | 2024-09-06 12:58:06 +0100 |
| commit | f32efa3e4bba5b3432d7932dc89bd2e36c5c0f49 (patch) | |
| tree | d16ec8c5b3b80d6f4ff63aa8a858a02239625f56 | |
| parent | f04b611e66503336bbdac04eb5a76d62932ce2e3 (diff) | |
perf/arm-cmn: Improve format attr printing
Take full advantage of our formats being stored in bitfield form, and
make the printing even more robust and simple by letting printk do all
the hard work of formatting bitlists.
Signed-off-by: Robin Murphy <[email protected]>
Reviewed-by: Ilkka Koskinen <[email protected]>
Link: https://lore.kernel.org/r/50459f2d48fc62310a566863dbf8a7c14361d363.1725474584.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <[email protected]>
| -rw-r--r-- | drivers/perf/arm-cmn.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 62d4782da7e4..397a46410f7c 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -1280,15 +1280,11 @@ static ssize_t arm_cmn_format_show(struct device *dev, struct device_attribute *attr, char *buf) { struct arm_cmn_format_attr *fmt = container_of(attr, typeof(*fmt), attr); - int lo = __ffs(fmt->field), hi = __fls(fmt->field); - - if (lo == hi) - return sysfs_emit(buf, "config:%d\n", lo); if (!fmt->config) - return sysfs_emit(buf, "config:%d-%d\n", lo, hi); + return sysfs_emit(buf, "config:%*pbl\n", 64, &fmt->field); - return sysfs_emit(buf, "config%d:%d-%d\n", fmt->config, lo, hi); + return sysfs_emit(buf, "config%d:%*pbl\n", fmt->config, 64, &fmt->field); } #define _CMN_FORMAT_ATTR(_name, _cfg, _fld) \ |