aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Shurong <[email protected]>2023-07-15 22:13:38 +0800
committerNeil Armstrong <[email protected]>2023-08-04 15:19:01 +0200
commitf2ed165619c16577c02b703a114a1f6b52026df4 (patch)
tree41c43d24a5dfb30c6cbfc24661e435406419c8c6
parent584ed6d4afca4824f3bf18e588cc0cb555278bff (diff)
firmware: meson_sm: fix to avoid potential NULL pointer dereference
of_match_device() may fail and returns a NULL pointer. Fix this by checking the return value of of_match_device. Fixes: 8cde3c2153e8 ("firmware: meson_sm: Rework driver as a proper platform driver") Signed-off-by: Zhang Shurong <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Neil Armstrong <[email protected]>
-rw-r--r--drivers/firmware/meson/meson_sm.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
index 798bcdb05d84..9a2656d73600 100644
--- a/drivers/firmware/meson/meson_sm.c
+++ b/drivers/firmware/meson/meson_sm.c
@@ -292,6 +292,8 @@ static int __init meson_sm_probe(struct platform_device *pdev)
return -ENOMEM;
chip = of_match_device(meson_sm_ids, dev)->data;
+ if (!chip)
+ return -EINVAL;
if (chip->cmd_shmem_in_base) {
fw->sm_shmem_in_base = meson_sm_map_shmem(chip->cmd_shmem_in_base,