diff options
author | Alex Yashchenko <[email protected]> | 2016-12-13 09:26:25 +0000 |
---|---|---|
committer | Herbert Xu <[email protected]> | 2016-12-14 18:33:14 +0800 |
commit | efcae7c931b473285e38c778bdaa9f36de9f78d6 (patch) | |
tree | b0079dc0efd34a5b56b992a1d32383f38ed2857a | |
parent | fbb726302a9ae06b373e04a54ad30eafa288dd10 (diff) |
sign-file: Fix inplace signing when src and dst names are both specified
When src and dst both are specified and they point to the same file
the sign-file utility will write only signature to the dst file and
the module (.ko file) body will not be written.
That happens because we open the same file with "rb" and "wb" flags,
from fopen man:
w Truncate file to zero length or create text file for writing.
The stream is positioned at the beginning of the file.
...
bm = BIO_new_file(module_name, "rb");
...
bd = BIO_new_file(dest_name, "wb");
...
while ((n = BIO_read(bm, buf, sizeof(buf))),
n > 0) {
ERR(BIO_write(bd, buf, n) < 0, "%s", dest_name);
}
...
Signed-off-by: Alex Yashchenko <[email protected]>
Signed-off-by: David Howells <[email protected]>
Signed-off-by: Herbert Xu <[email protected]>
-rwxr-xr-x | scripts/sign-file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/sign-file.c b/scripts/sign-file.c index 53af6dc3e6c1..19ec468b1168 100755 --- a/scripts/sign-file.c +++ b/scripts/sign-file.c @@ -267,7 +267,7 @@ int main(int argc, char **argv) } x509_name = argv[2]; module_name = argv[3]; - if (argc == 5) { + if (argc == 5 && strcmp(argv[3], argv[4]) != 0) { dest_name = argv[4]; replace_orig = false; } else { |