diff options
author | Arnaldo Carvalho de Melo <[email protected]> | 2017-04-07 12:19:38 -0300 |
---|---|---|
committer | Arnaldo Carvalho de Melo <[email protected]> | 2017-04-11 15:23:39 -0300 |
commit | ecbe5e10d4ad12dd3da5d9fccd153c529c8c8ce1 (patch) | |
tree | b24dd13689e734daf441ea219efeb742bf8c73c4 | |
parent | bdd97ca63faa374c98314d53c0bcaedb473c5a33 (diff) |
perf string: Simplify ltrim() implementation
We don't need to use strlen(), a var, or check for the end explicitely,
isspace('\0') is false:
[acme@jouet c]$ cat ltrim.c
#include <ctype.h>
#include <stdio.h>
static char *ltrim(char *s)
{
while (isspace(*s))
++s;
return s;
}
int main(void)
{
printf("ltrim(\"\")='%s'\n", ltrim(""));
return 0;
}
[acme@jouet c]$ ./ltrim
ltrim("")=''
[acme@jouet c]$
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Taeung Song <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
-rw-r--r-- | tools/perf/util/string.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/tools/perf/util/string.c b/tools/perf/util/string.c index bddca519dd58..e8feb142c9c9 100644 --- a/tools/perf/util/string.c +++ b/tools/perf/util/string.c @@ -322,12 +322,8 @@ char *strxfrchar(char *s, char from, char to) */ char *ltrim(char *s) { - int len = strlen(s); - - while (len && isspace(*s)) { - len--; + while (isspace(*s)) s++; - } return s; } |