diff options
| author | Lee Jones <[email protected]> | 2020-06-25 09:39:11 +0100 |
|---|---|---|
| committer | Lee Jones <[email protected]> | 2020-07-06 08:32:05 +0100 |
| commit | ec46855df33973ac6ed646e26cc8977b97cc7cd0 (patch) | |
| tree | 61b441e8d1865508a6d7ac68e7edbe2cb4cfc386 | |
| parent | 768c1e38dc43b1fc43f73409f58c58344f243892 (diff) | |
mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting
'i / pdata->num_irqs' always equates to 0 and 'BIT(i % pdata->num_irqs)'
always ends up being BIT(i) here, so make that clearer in the code. If
the code base needs to support more than 32 IRQs in the future, this will
have to be reworked, but lets just keep it simple for as long as we can.
This fixes the following W=1 warning:
drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero
Cc: Orson Zhai <[email protected]>
Cc: Chunyan Zhang <[email protected]>
Suggested-by: Baolin Wang <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
Reviewed-by: Baolin Wang <[email protected]>
Signed-off-by: Lee Jones <[email protected]>
| -rw-r--r-- | drivers/mfd/sprd-sc27xx-spi.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index d3486c2a1b33..f8a8b918c60d 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -185,10 +185,8 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { - ddata->irqs[i].reg_offset = i / pdata->num_irqs; - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); - } + for (i = 0; i < pdata->num_irqs; i++) + ddata->irqs[i].mask = BIT(i); ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq, IRQF_ONESHOT | IRQF_NO_SUSPEND, 0, |