aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWenchao Hao <[email protected]>2022-03-17 11:01:16 -0400
committerMartin K. Petersen <[email protected]>2022-03-29 23:01:28 -0400
commitebfe3e0c5e805da3dd692bb120cd6269b7c19b80 (patch)
tree42461c6a88eea4ebd3e13f4b99d0ddec169a3d92
parent87d663d40801dffc99a5ad3b0188ad3e2b4d1557 (diff)
scsi: libiscsi: Remove unnecessary memset() in iscsi_conn_setup()
iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is zero filled already including the dd_data. So it is unnecessary to call memset again. Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Wu Bo <[email protected]> Reviewed-by: Lee Duncan <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Wenchao Hao <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
-rw-r--r--drivers/scsi/libiscsi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index d09926e6c8a8..cf4211c6500d 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -3045,7 +3045,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size,
if (!cls_conn)
return NULL;
conn = cls_conn->dd_data;
- memset(conn, 0, sizeof(*conn) + dd_size);
conn->dd_data = cls_conn->dd_data + sizeof(*conn);
conn->session = session;