diff options
| author | Michal Wajdeczko <[email protected]> | 2017-12-19 11:43:45 +0000 |
|---|---|---|
| committer | Chris Wilson <[email protected]> | 2017-12-19 15:07:06 +0000 |
| commit | eb10ed9a9e1ecacafab5535c86b62061b39360e5 (patch) | |
| tree | 9cdda93207904cf11750d5969be65057aeb00cf1 | |
| parent | a8c9b8496954e36fb1be205e1287f020a2923b4d (diff) | |
drm/i915: Convert intel_device_info_dump into pretty printer
Convert intel_device_info_dump into pretty printer to be
consistent with the rest of the driver code.
Suggested-by: Chris Wilson <[email protected]>
Signed-off-by: Michal Wajdeczko <[email protected]>
Cc: Chris Wilson <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
Signed-off-by: Chris Wilson <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
| -rw-r--r-- | drivers/gpu/drm/i915/i915_drv.c | 6 | ||||
| -rw-r--r-- | drivers/gpu/drm/i915/i915_drv.h | 3 | ||||
| -rw-r--r-- | drivers/gpu/drm/i915/intel_device_info.c | 22 |
3 files changed, 17 insertions, 14 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 72bea281edb7..6f14986dcd11 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c @@ -931,7 +931,11 @@ static int i915_driver_init_early(struct drm_i915_private *dev_priv, intel_display_crc_init(dev_priv); - intel_device_info_dump(dev_priv); + if (drm_debug & DRM_UT_DRIVER) { + struct drm_printer p = drm_debug_printer("i915 device info:"); + + intel_device_info_dump(&dev_priv->info, &p); + } intel_detect_preproduction_hw(dev_priv); diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 26ebc7038e5e..eb4f6d7d8755 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -4164,7 +4164,8 @@ mkwrite_device_info(struct drm_i915_private *dev_priv) const char *intel_platform_name(enum intel_platform platform); void intel_device_info_runtime_init(struct drm_i915_private *dev_priv); -void intel_device_info_dump(struct drm_i915_private *dev_priv); +void intel_device_info_dump(const struct intel_device_info *info, + struct drm_printer *p); void intel_device_info_dump_flags(const struct intel_device_info *info, struct drm_printer *p); diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index 5a385a910755..be355cf2976e 100644 --- a/drivers/gpu/drm/i915/intel_device_info.c +++ b/drivers/gpu/drm/i915/intel_device_info.c @@ -77,21 +77,19 @@ void intel_device_info_dump_flags(const struct intel_device_info *info, #undef PRINT_FLAG } -void intel_device_info_dump(struct drm_i915_private *dev_priv) +void intel_device_info_dump(const struct intel_device_info *info, + struct drm_printer *p) { - const struct intel_device_info *info = &dev_priv->info; + struct drm_i915_private *dev_priv = + container_of(info, struct drm_i915_private, info); - DRM_DEBUG_DRIVER("i915 device info: platform=%s gen=%i pciid=0x%04x rev=0x%02x", - intel_platform_name(info->platform), - info->gen, - dev_priv->drm.pdev->device, - dev_priv->drm.pdev->revision); + drm_printf(p, "pciid=0x%04x rev=0x%02x platform=%s gen=%i\n", + INTEL_DEVID(dev_priv), + INTEL_REVID(dev_priv), + intel_platform_name(info->platform), + info->gen); - if (drm_debug & DRM_UT_DRIVER) { - struct drm_printer p = drm_debug_printer("i915 device info: "); - - intel_device_info_dump_flags(info, &p); - } + intel_device_info_dump_flags(info, p); } static void gen10_sseu_info_init(struct drm_i915_private *dev_priv) |